Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA #4438

Closed
wants to merge 1 commit into from
Closed

8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA #4438

wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 9, 2021 •
edited by openjdk bot

Hi all,

could you please review this small test-only patch?
from JBS:

execution of runtime/InvocationTests w/ -XX:-UseVtableBasedCHA can be instrumental in finding bugs in the old implementation of CHA.

the patch adds a new test invocationOldCHATests.java which is based on invocationC1Tests.java but runs the tests w/ -Xcomp -XX:+UnlockDiagnosticVMOptions -XX:-UseVtableBasedCHA.

testing: invocationOldCHATests.java on {linux,windows,macosx}-x64

Thanks,
-- Igor

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4438/head:pull/4438
$ git checkout pull/4438

Update a local copy of the PR:
$ git checkout pull/4438
$ git pull https://git.openjdk.java.net/jdk pull/4438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4438

View PR using the GUI difftool:
$ git pr show -t 4438

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4438.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8268475 8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA Jun 9, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 9, 2021
@iignatev
Copy link
Member Author

iignatev commented Jun 9, 2021

/cc hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@iignatev
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 9, 2021

Webrevs

mseledts
mseledts approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@mseledts mseledts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please fix the copyright note before integration.

test/hotspot/jtreg/runtime/InvocationTests/invocationOldCHATests.java
@@ -0,0 +1,81 @@
/*
* Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new test, should this be just 2021, no 2019?

Copy link
Member Author

@iignatev iignatev Jun 9, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this file (and the majority of its code) is based on the file which was originated in 2019, hence I believe it should be 2019.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks for clarification.

@openjdk
Copy link

openjdk bot commented Jun 9, 2021 •
edited

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA

Reviewed-by: mseledtsov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • bbd0313: 8263203: jconsole Online User Guide has wrong URL
  • 33d34c6: 8263323: Debug Agent help output includes invalid URL
  • 79010f2: 8266835: Add a --validate option to the jar tool

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2021
@iignatev
Copy link
Member Author

Misha, Vladimir, thank you for your reviews.

/integrate

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev Since your change was applied there have been 10 commits pushed to the master branch:

  • f839308: 8268407: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-aarch64 due to JDK-8268211
  • 58ba48b: 8268192: LambdaMetafactory with invokespecial causes VerificationError
  • b41f3f8: 8268478: JVMCI tests failing after JDK-8268052
  • 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
  • 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
  • bf29a01: 8228343: JCMD and attach fail to work across Linux Container boundary
  • 408e0a9: 8255148: Confusing log output: SSLSocket duplex close failed
  • bbd0313: 8263203: jconsole Online User Guide has wrong URL
  • 33d34c6: 8263323: Debug Agent help output includes invalid URL
  • 79010f2: 8266835: Add a --validate option to the jar tool

Your commit was automatically rebased without conflicts.

Pushed as commit 2623b0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseledts mseledts mseledts approved these changes

@vnkozlov vnkozlov vnkozlov approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
3 participants
@iignatev @vnkozlov @mseledts